change reactrenderer component type definition #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for tiptap-embed ready! 🔨 Explore the source changes: 2534f54 🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61cc85f43811e50007892da8 😎 Browse the preview: https://deploy-preview-2327--tiptap-embed.netlify.app |
|
Looks good. Thanks! |
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the ReactRenderer types so that they are no longer tied to the
mentionexample.#2011 makes the
ComponentTyperequireitems[]and acommandin the props, but the ReactRenderer does not make the same assumption.I think this should also make it possible to change the type of
propsin theReactRendererclass toP, and similarly in the function definition forReactRenderer.updateProps. But I wanted this to be a minimal change so I just fixed the issue in theComponentTypetype definition.